Skip to content

Do not log the addresses of connection objects in ConnectionPool (apache/pulsar-client-cpp#628) - #2

Open
alexey-milovidov wants to merge 2 commits into
clickhousefrom
upstream-pr-628
Open

alexey-milovidov wants to merge 2 commits into
clickhousefrom
upstream-pr-628

Conversation

@alexey-milovidov

Copy link
Copy Markdown
Member

Merges the upstream pull request apache#628 into the clickhouse branch.

The change itself is already in clickhouse as c162ff9. The only difference is the line wrapping that clang-format produces upstream, so this pull request makes the fork identical to the upstream pull request in lib/ConnectionPool.cc and avoids a conflict when upstream merges it.

Related: apache#628
Related: ClickHouse/ClickHouse#64184

🤖 Generated with Claude Code

alexey-milovidov and others added 2 commits November 13, 2026 23:43
The connection reuse and stale connection logs printed the raw heap address
of the connection object, which ends up in the host application logs (e.g.
`system.text_log` in ClickHouse) and discloses the memory layout.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The change itself (do not log the addresses of connection objects in
`ConnectionPool`) is already in the `clickhouse` branch as c162ff9.
The merge takes the line wrapping of the upstream pull request, so that
the fork does not diverge from upstream once it is merged there.

apache#628

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant